Do not choke on MessageSet without version #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we end un unlucky and MessageSet buffer is truncated right before we can read magic value, we just return `ErrInsufficientData`, even if some messages were previously successfully parsed. This propagates all the way up to `partitionConsumer`, where we zero parsed messages, which results in `ErrMessageTooLarge` returned to the consumer. This commit fixes the issue by setting `PartialTrailingMessage` to `true` on `MessageSet`, making it possible to read successfully parsed messages.
|
Nice find, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we end un unlucky and MessageSet buffer is truncated right before
we can read magic value, we just return
ErrInsufficientData, evenif some messages were previously successfully parsed.
This propagates all the way up to
partitionConsumer, where we zeroparsed messages, which results in
ErrMessageTooLargereturnedto the consumer.
This commit fixes the issue by setting
PartialTrailingMessagetotrueon
MessageSet, making it possible to read successfully parsed messages.